feat(homepage): add git button and split css styles #1

Open

aleksa wants to merge 3 commits from dev into main

pull from: dev

merge into: aleksa:main

aleksa:main

Conversation 4 Commits 3 Files changed 4 +43 -20

aleksa commented 2025-04-17 01:35:47 +00:00

Owner

Copy link

• Added a git button to link to my personal git profile (this one!).
• Split global.css into global.css and homepage.css to prevent global getting cluttered with single-use elements.

- Added a git button to link to my personal git profile (this one!). - Split global.css into global.css and homepage.css to prevent global getting cluttered with single-use elements.

aleksa self-assigned this 2025-04-17 01:35:47 +00:00

aleksa added 1 commit 2025-04-17 01:35:47 +00:00

feat(homepage): add git button and split css styles 1e443c6b43

aleksa added 1 commit 2025-04-17 01:47:11 +00:00

ci: remove redundant push trigger for main 2fccb3bb56

aleksa commented 2025-04-17 01:49:14 +00:00

Author

Owner

Copy link

• Removed main branch push trigger as pushing to main directly will not be happening. It was accidentally left in from me testing the workflow on another test repo. Also included in this PR since it is very minor.

- Removed main branch push trigger as pushing to main directly will not be happening. It was accidentally left in from me testing the workflow on another test repo. Also included in this PR since it is very minor.

aleksa added 1 commit 2025-04-17 02:06:08 +00:00

fix(layout): use dvh to prevent mobile scroll issues 3770e67898

aleksa commented 2025-04-17 02:07:37 +00:00

Author

Owner

Copy link

• Switched vh to dvh to prevent the page being too long vertically on mobile due to the browser and other mobile UI elements stealing screen real estate.

- Switched vh to dvh to prevent the page being too long vertically on mobile due to the browser and other mobile UI elements stealing screen real estate.

aleksa commented 2025-04-19 02:51:25 +00:00

Author

Owner

Copy link

I need to add more Cypress tests for the new element. This will become a regular thing where i add e2e tests for every addition to make sure the test coverage is as high as possible. I will do the same thing when I start incorporating more testing types.

I tried using the default Cypress hover event to test the button changing style on hover but it doesn't work properly, so I will get cypress-real-events to enable better e2e test interactions. This was recommended by most people complaining about default Cypress event implementations since they just use JS to simulate events instead of executing them natively.

I need to add more Cypress tests for the new element. This will become a regular thing where i add e2e tests for every addition to make sure the test coverage is as high as possible. I will do the same thing when I start incorporating more testing types. I tried using the default Cypress hover event to test the button changing style on hover but it doesn't work properly, so I will get `cypress-real-events` to enable better e2e test interactions. This was recommended by most people complaining about default Cypress event implementations since they just use JS to simulate events instead of executing them natively.

aleksa commented 2025-04-21 00:48:45 +00:00

Author

Owner

Copy link

cypress-real-events works for hovering and the style change is visible in the video, but cy.screenshot() doesn't capture it. I am looking into this for a while now but there doesn't seem to be a solution and even the official documentation for cypress-real-events says so: realHover explanation.

I hope to find a different solution for testing hover since I do not want to force a CSS change as it is usually done but I want to simulate a real hover somehow. If it proves to be impossible tho, I might just stick to adding hover as a class.

`cypress-real-events` works for hovering and the style change is visible in the video, but `cy.screenshot()` doesn't capture it. I am looking into this for a while now but there doesn't seem to be a solution and even the official documentation for `cypress-real-events` says so: [realHover explanation](https://github.com/dmtrKovalenko/cypress-real-events?tab=readme-ov-file#1-why-cyrealhover-hovering-state-does-not-show-in-the-visual-regression-services). I hope to find a different solution for testing hover since I do not want to force a CSS change as it is usually done but I want to simulate a real hover somehow. If it proves to be impossible tho, I might just stick to adding `hover` as a class.

All checks were successful

Hide all checks

E2E Tests with Cypress / cypress (push) Successful in 3m4s

Details

E2E Tests with Cypress / cypress (pull_request) Successful in 3m0s

Details

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin dev:dev

git checkout dev

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main

git merge --no-ff dev

git checkout dev

git rebase main

git checkout main

git merge --ff-only dev

git checkout dev

git rebase main

git checkout main

git merge --no-ff dev

git checkout main

git merge --squash dev

git checkout main

git merge --ff-only dev

git checkout main

git merge dev

git push origin main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

aleksa

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: aleksa/aleksa.sh#1

No description provided.